Skip to content

CODEOWNERS functionality is only triggered when opening a PR, but not after changes #33490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Merciful12 opened this issue Feb 4, 2025 · 1 comment · Fixed by #33744
Closed
Labels
Milestone

Comments

@Merciful12
Copy link

Description

When a new PR is opened CODEOWNERS functionality is triggered, but afterwards changes in the PR don't trigger CODEOWNERS functionality again.

For example I have next CODEOWNERS:

file1.js @user1
file2.js @user2

If I change file1.js and open a new PR, user1 will be assigned as a reviewer. Then I change file2.js in the same branch so the PR has 2 changed files: file1.js and file2.js but CODEOWNER of file2.js (user2) is not assigned as a reviewer

Gitea Version

1.23.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Not relevant

Database

None

@jpraet
Copy link
Member

jpraet commented Feb 27, 2025

This feels quite important to fix. CODEOWNERS feature can be used for audits about PR's that touch certain files.
CODEOWNERS reviews not triggering when the file is modified after the creation of the PR definitely does not meet the user expectation.

lunny added a commit that referenced this issue Mar 14, 2025
…33744)

Fix #33490 

It will only read the changed file on the pushed commits but not all the
files of this PR.

---------

Co-authored-by: wxiaoguang <[email protected]>
lunny added a commit to lunny/gitea that referenced this issue Mar 28, 2025
…o-gitea#33744)

Fix go-gitea#33490

It will only read the changed file on the pushed commits but not all the
files of this PR.

---------

Co-authored-by: wxiaoguang <[email protected]>
@lunny lunny added this to the 1.23.7 milestone Mar 28, 2025
lunny added a commit that referenced this issue Mar 28, 2025
…33744) (#34045)

Fix #33490
Backport #33744 

It will only read the changed file on the pushed commits but not all the
files of this PR.

Co-authored-by: wxiaoguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants