Clicking on the Code-tab leads to invalid URL

[cleverer]

• Gitea version (or commit ref): 1.4.2
• Git version: 2.17.0
• Operating system: macOS 10.13.4
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No, but on https://git.damutten.ch/Nicolas/todolist
  • Not relevant
• Log gist:

Description

When browsing a tag, clicking on the Code-tab leads to an invalid url/404. It incorrectly gets linked to src/branch/tagname instead of src/tag/tagname.

Screenshots

[johnrazeur]

Hello,
it's a regression caused by #3776.
I can try to fix this if a maintainer allows me !

[daviian]

As far as I see this issue only occurs on the release/1.4 branch and not on master. Is this correct?

@johnrazeur of course, we are happy if you do!

[johnrazeur]

Yes, the issue doesn't occurs on master.

[cleverer]

@daviian It seems like it, yes. Just wanted to comment on it, but you were a few seconds faster…
I reinstalled it with brew reinstall --devel and it works like a charm now.

@johnrazeur Thanks for offering to help!

I'm closing the issue for now.

[lunny]

@cleverer I would like stay this on v1.4.3 @johnrazeur please send a PR to release/v1.4

[cleverer]

Found the commit, which fixes the behaviour: 3a6f3c8, #3908

[daviian]

Fixed by #4263