-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Login Captcha #6049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Here is a potential development plan for solving the current issue: Add to User model a new column If the LoginAttempts become bigger than X, in the sign in form a new captcha field will appear. I think we could use the existing configuration flag in order to know if we should force captcha checking after X failed attempts. |
@savionok I think a new column in |
@lunny if we are trying to stop a hack attempt by putting a captcha and reducing the odds that it's a robot attempt, we should not trust the session cookies, I believe. 🤔 |
@guillep2k Currently we allow one user login serval times, maybe one for your personal computer, one for working computer and one for your mobile. So store it on database one column will result in other things. If we want to do that, we needs a device management table. Of course we can do that for a long consideration. We have depended on session cookies on login I think. Once you have a different cookie value when you logined, you will be logout. |
@lunny Captchas are normally meant to tell humans from robots that can be doing a dictionary attack. If that's not our intention, why use a captcha at all? Robots will certainly not honor session cookies. 👾 Any cookies kept in the real user's computers should not be affected in any way. If they were valid, they should remain valid. No problems there. As I understand it, the Tools like RSS readers or even git's HTTP protocol will not be affected by this because they don't use the login form. |
I agree @guillep2k this can be global per user and reset to zero on successful authorization |
We should probably also keep last failed authorization timestamp so that we can discard failure count after x minutes has passed |
What about this nice feature? Seems really useful. I would add, that admin should be able to configure login attempts to 0 that should drive to show captcha on each login attempt. How about not existing users attempts? |
i prefer a captcha just for login. |
Enable this to require captcha validation for user login. You also must enable `ENABLE_CAPTCHA`. Summary: - Consolidate CAPTCHA template - add CAPTCHA handle and context - add `REQUIRE_CAPTCHA_FOR_LOGIN` config and docs - Consolidate CAPTCHA set-up and verification code Partially resolved #6049 Signed-off-by: Xinyu Zhou <[email protected]> Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Andrew Thornton <[email protected]>
Closed as #21906 opened. |
How about login captcha?
Force to solve captcha if user tried to login 3 times with wrong password.
The text was updated successfully, but these errors were encountered: