-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix profile page CSS #10406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix profile page CSS #10406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
silverwind
reviewed
Feb 21, 2020
Signed-off-by: jolheiser <[email protected]>
silverwind
approved these changes
Feb 21, 2020
CI failed. |
lafriks
approved these changes
Feb 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #10406 +/- ##
==========================================
- Coverage 43.79% 43.69% -0.11%
==========================================
Files 586 586
Lines 81121 81351 +230
==========================================
+ Hits 35529 35546 +17
- Misses 41197 41405 +208
- Partials 4395 4400 +5
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9980
Same as the usual fomantic changes, the styles were changed and no longer applied.
I chose the units based on a working version of Gitea and spying on the rendered styles on the page.
Somehow this style looks correct on my
1.11
instance (which is when fomantic was added)...so I'm not sure whether this needs a backport or not...