Skip to content

models: break out of loop #12386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Jul 31, 2020

I thought I got all of these in 56f222d, but apparently there was still a stray.

This fixes a break inside a switch inside a for loop, which was only making it past the switch.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 31, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 31, 2020
@lunny lunny added this to the 1.13.0 milestone Jul 31, 2020
@lunny lunny merged commit e4d6f2e into go-gitea:master Jul 31, 2020
@lunny
Copy link
Member

lunny commented Jul 31, 2020

Please send back port to v1.12

zeripath pushed a commit to zeripath/gitea that referenced this pull request Aug 22, 2020
@zeripath zeripath added the backport/done All backports for this PR have been created label Aug 22, 2020
zeripath added a commit that referenced this pull request Aug 22, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants