Prevent empty div when editing comment #12404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template for attachments needs to remove whitespace and return empty when there are no attachments. Fix go-gitea#10220 Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
|
Could be backported to v1.12 |
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Aug 2, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Aug 4, 2020
GiteaBot
added
lgtm/done
|
for everybody who like to have the documentation of the template changes: |
|
make lg-tm work |
8 tasks
techknowlogick
pushed a commit
to techknowlogick/gitea
that referenced
this pull request
Sep 30, 2020
* Prevent empty div when editing comment The template for attachments needs to remove whitespace and return empty when there are no attachments. Fix go-gitea#10220
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Sep 30, 2020
* Prevent empty div when editing comment The template for attachments needs to remove whitespace and return empty when there are no attachments. Fix go-gitea#10220
|
backport: #12992 |
lunny
pushed a commit
that referenced
this pull request
Oct 1, 2020
* Prevent empty div when editing comment The template for attachments needs to remove whitespace and return empty when there are no attachments. Fix #10220 Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template for attachments needs to remove whitespace and return an empty response when there are no attachments.
Fix #10220
Signed-off-by: Andrew Thornton [email protected]