Skip to content

Add captcha support to OpenID based signup #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

strk
Copy link
Member

@strk strk commented Mar 17, 2017

No description provided.

@lunny lunny added this to the 1.2.0 milestone Mar 18, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 18, 2017
@lunny
Copy link
Member

lunny commented Mar 18, 2017

maybe some screenshots?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2017
@strk
Copy link
Member Author

strk commented Mar 18, 2017 via email

@pgaskin
Copy link
Contributor

pgaskin commented Mar 19, 2017

Maybe some screenshots so we can see the nice captchas? 😃 LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2017
@lunny
Copy link
Member

lunny commented Mar 20, 2017

LGTM except @geek1011 's comment.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2017
@strk
Copy link
Member Author

strk commented Mar 20, 2017

@bkcsoft can you merge now ? :)

captcha

@bkcsoft bkcsoft merged commit 97ee889 into go-gitea:master Mar 20, 2017
@strk strk deleted the openid-captcha branch March 20, 2017 08:04
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants