-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Show status check for merged PRs #13975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is pretty straightforward and I don't see any potential issues with it; basically copies what non-merged PRs do
This is little more complicated because it changes how status is fetched for PR, maybe @zeripath could chime on on potential performance issues with this |
Codecov Report
@@ Coverage Diff @@
## master #13975 +/- ##
==========================================
- Coverage 42.20% 42.19% -0.01%
==========================================
Files 710 710
Lines 77273 77280 +7
==========================================
- Hits 32612 32610 -2
- Misses 39288 39296 +8
- Partials 5373 5374 +1
Continue to review full report at Codecov.
|
Not sure this qualifies as |
I think essentially this about showing stuff on the UI -> Therefore kind/ui! |
The status information may be deleted when sometime? |
We don't remove statuses from database (and we shouldn't, if that's what you ask for - it's a valid piece of information just like comments made by users), so unless someone were to remove it manually (in which case it will not display anything as if commit never had any statuses), no. |
The ancient commit statuses are unuseful, especially for a big repository which has over ten thousands of commits. But they will reduce the performance of commit statuses table. So I think we should allow to delete merged or closed PR's commits statuses which haven't been merged to the git tree. And of course, the PR is work even if the commit status deleted I think. |
Yes the PR will work even if you were to allow removal of old statuses, it will just act as if there was no status and won't show anything (just like right now). |
File conflicts |
🚀 |
This PR allows Gitea to show status check for merged PRs: