-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
chore(models): rewrite code format. #14754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ironically for a linting pr this one has caused a linting failure... Following this pr are you able to remove any special exemptions for models/ from golangcilint? |
but what reason/impact do |
it's more a stylistic issue. In general in our code we use |
@appleboy pull got conflicts & CI still failing :/ |
@6543 I will take it. |
Signed-off-by: Bo-Yi Wu <[email protected]>
Signed-off-by: Bo-Yi Wu <[email protected]>
@6543 Done. Please help to review. |
I like |
Codecov Report
@@ Coverage Diff @@
## master #14754 +/- ##
==========================================
- Coverage 42.24% 42.23% -0.01%
==========================================
Files 774 774
Lines 83008 83011 +3
==========================================
- Hits 35068 35061 -7
- Misses 42243 42252 +9
- Partials 5697 5698 +1
Continue to review full report at Codecov.
|
var a
=>a:
//xxxx
=>// xxx