Even more repo rework #15005
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| <div class="ui detail icon mini button"> | ||
| {{if .verification.Verified}} | ||
| <div title="{{if eq .verification.TrustStatus "trusted"}}{{else if eq .verification.TrustStatus "untrusted"}}{{$.root.i18n.Tr "repo.commits.signed_by_untrusted_user"}}: {{else}}{{$.root.i18n.Tr "repo.commits.signed_by_untrusted_user_unmatched"}}: {{end}}{{.verification.Reason}}"> | ||
| {{if ne .verification.SigningUser.ID 0}} | ||
| {{svg "gitea-lock" 12}} | ||
| {{avatar .verification.SigningUser 28 "signature"}} | ||
| {{else}} | ||
| <span title="{{$.root.i18n.Tr "gpg.default_key"}}">{{svg "gitea-lock-cog" 12}}</span> | ||
| {{avatarByEmail .verification.SigningEmail "" 28 "signature"}} | ||
| {{end}} | ||
| </div> | ||
| {{else}} | ||
| <span title="{{$.root.i18n.Tr .verification.Reason}}">{{svg "gitea-unlock" 12}}</span> | ||
| {{end}} | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,7 @@ import octiconProject from '../../public/img/svg/octicon-project.svg'; | |
| import octiconRepo from '../../public/img/svg/octicon-repo.svg'; | ||
| import octiconRepoForked from '../../public/img/svg/octicon-repo-forked.svg'; | ||
| import octiconRepoTemplate from '../../public/img/svg/octicon-repo-template.svg'; | ||
| import octiconX from '../../public/img/svg/octicon-x.svg'; | ||
|
|
||
| export const svgs = { | ||
| 'octicon-chevron-down': octiconChevronDown, | ||
|
|
@@ -28,6 +29,7 @@ export const svgs = { | |
| 'octicon-repo': octiconRepo, | ||
| 'octicon-repo-forked': octiconRepoForked, | ||
| 'octicon-repo-template': octiconRepoTemplate, | ||
| 'octicon-x': octiconX, | ||
| }; | ||
|
|
||
| const parser = new DOMParser(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1390,6 +1390,23 @@ i.icon.centerlock { | |
| color: var(--color-text-light); | ||
| } | ||
|
|
||
| .ui.active.label { | ||
| background: var(--color-secondary); | ||
| border-color: var(--color-secondary); | ||
| color: var(--color-text-dark); | ||
| } | ||
|
|
||
| .ui.active.label:hover, | ||
| a.ui.active.label:hover { | ||
| background: var(--color-secondary-dark-1); | ||
| color: var(--color-text-dark); | ||
| } | ||
|
|
||
| .ui.form .field.error .ui.multiple.selection.dropdown > .red.label { | ||
| color: #e7b6b6 !important; | ||
| background: #871717 !important; | ||
|
There was a problem hiding this comment. I invented these colors as I said in OP. I meant exactly this by "formalizing" - they have to fit into some scheme. I'd rather not use extra long names for this single use instance. I just didn't spot on cases where these colors could be shared... yet. Any suggestions? There was a problem hiding this comment. Maybe There was a problem hiding this comment. That would mean we'd better go deeper and override more stuff from Fomantic UI, which was not the main goal of this PR. Of course, since we are on it, I'll see what I can do. I mean to put all colors used in Semantic Dropdown into |
||
| } | ||
|
|
||
|
There was a problem hiding this comment. Can we maybe not use nested syntax to override fomantic? I prefer plain selectors in this case because it's easiert to search exact selector strings in fomantic source and just copy from there. Nested syntax would break this searching. |
||
| .ui.labels a.label:hover, | ||
| a.ui.label:hover { | ||
| background: var(--color-hover); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,7 @@ | |
| } | ||
|
|
||
| .ui.tags { | ||
| margin-top: -.5rem; | ||
| margin-bottom: .5rem; | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is personal taste: I don't want to have
<svg>elements generated bysvg.jsandhelper.goto have different order of class names. I originally planned to deduplicate the class names (like insvg.js) but that would add unnecessary costs with no added benefit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should move
regexp.MustCompileout of the function to not compile the regex every function call.