Skip to content

Add correct git branch name validation #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add correct git branch name validation #1503

wants to merge 4 commits into from

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Apr 16, 2017

Fix #1499

@andreynering andreynering modified the milestone: 1.2.0 Apr 16, 2017
@lafriks lafriks mentioned this pull request Apr 17, 2017
Merged
@lunny
Copy link
Member

lunny commented Apr 18, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 18, 2017
@appleboy
Copy link
Member

@lafriks Please fix the conflicts.

@lafriks
Copy link
Member Author

lafriks commented Apr 19, 2017

As #1507 was depending on this pull request it contained also these changes, so this pull request can just be closed as all required changes was merged in with #1507

@lafriks lafriks closed this Apr 19, 2017
@lunny lunny removed this from the 1.2.0 milestone Apr 19, 2017
@lafriks lafriks deleted the issue/1499 branch May 7, 2017 16:45
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow "/" in branch name when creating new branch from online editor
5 participants
@lafriks @lunny @appleboy @tboerger @andreynering