feat: add download count field and unit testing for attachment. #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It takes a migration to add that new field, right ? |
tboerger
added
the
lgtm/need 2
|
@strk Yes. |
bkcsoft
suggested changes
Apr 19, 2017
| assert.NoError(t, PrepareTestDatabase()) | ||
|
|
||
| attachment, err := GetAttachmentByUUID("1234567890") | ||
| assert.NoError(t, err) |
There was a problem hiding this comment.
assert.Equal(t, attachment.DownloadCount, int64(0)) ?
appleboy
changed the title
bkcsoft
approved these changes
Apr 19, 2017
|
LGTM |
tboerger
added
lgtm/need 1
lunny
added
the
type/feature
|
isn't this still lacking a migration ? |
bkcsoft
suggested changes
Apr 19, 2017
models/attachment.go
Outdated
| CommentID int64 | ||
| ReleaseID int64 `xorm:"INDEX"` | ||
| Name string | ||
| DownloadCount int64 |
There was a problem hiding this comment.
Instead of migration, do this:
DownloadCount int64 `xorm:"DEFAULT 0"`
There was a problem hiding this comment.
I remember @lunny calling for always adding a migration, not sure why
There was a problem hiding this comment.
It's better to do that. I think we can begin to ask all schema changes should use https://github.com/go-xorm/xorm/tree/master/migrate
Signed-off-by: Bo-Yi Wu <[email protected]>
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attachmenttable. See GitHub API