Skip to content

Do not show empty collaborators segment #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2017

Conversation

Morlinest
Copy link
Member

When there is no collaborator:
Before:
chrome_2017-04-22_12-22-36

After:
image

1+ collaborator - remains same:
chrome_2017-04-22_12-22-01

@lunny lunny added this to the 1.2.0 milestone Apr 22, 2017
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 22, 2017
@lunny
Copy link
Member

lunny commented Apr 22, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 22, 2017
@strk
Copy link
Member

strk commented Apr 22, 2017

Is it me or the "Before" and "After" screenshots are identical ?

@cez81
Copy link
Contributor

cez81 commented Apr 22, 2017

The dark grey line is thicker in the before screenshot.

@pgaskin
Copy link
Contributor

pgaskin commented Apr 22, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 22, 2017
@lunny lunny merged commit 5b8fe1e into go-gitea:master Apr 23, 2017
@Morlinest Morlinest deleted the fix-settings-collaboration-ui branch April 23, 2017 08:40
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jan 23, 2025
- Currently emojis that are part of the label's name aren't rendered
when shown in the popup that you get when you hover over issue
references.
- This patch fixes that by rendering the emoji.
- Adds CSS to not make the emoji big in the label.
- Resolves go-gitea#1531
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants