Set autocomplete off on branches selector

[zeripath]

Fix #15782

Signed-off-by: Andrew Thornton [email protected]

[codecov-commenter]

Codecov Report

Merging #15809 (a2dce38) into main (2dc3e4e) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #15809      +/-   ##
==========================================
+ Coverage   43.92%   44.00%   +0.08%     
==========================================
  Files         681      681              
  Lines       82228    82228              
==========================================
+ Hits        36120    36187      +67     
+ Misses      40205    40133      -72     
- Partials     5903     5908       +5     

Impacted Files	Coverage Δ
modules/git/repo_commit.go	40.00% <0.00%> (-0.87%)	⬇️
models/error.go	39.84% <0.00%> (+0.31%)	⬆️
services/pull/pull.go	43.37% <0.00%> (+0.45%)	⬆️
models/notification.go	66.07% <0.00%> (+0.88%)	⬆️
modules/notification/notification.go	87.60% <0.00%> (+2.47%)	⬆️
modules/notification/base/null.go	78.94% <0.00%> (+2.63%)	⬆️
modules/notification/mail/mail.go	38.77% <0.00%> (+5.10%)	⬆️
models/issue_comment.go	52.58% <0.00%> (+5.89%)	⬆️
modules/notification/ui/ui.go	65.81% <0.00%> (+6.83%)	⬆️
modules/util/timer.go	85.71% <0.00%> (+42.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc3e4e...a2dce38. Read the comment docs.

[silverwind]

Hmm I think we rather want to prevent the element from getting autofocus, autocomplete may still be useful.

[zeripath]

Hmm I think we rather want to prevent the element from getting autofocus, autocomplete may still be useful.

This is precisely how fomantic's dropdown.js prevents this box from appearing.

gitea/web_src/fomantic/build/semantic.js

Lines 3806 to 3813 in d37a89e

	if( module.is.search() && !module.has.search() ) {
	module.verbose('Adding search input');
	$search = $('<input />')
	.addClass(className.search)
	.prop('autocomplete', 'off')
	.insertBefore($text)
	;
	}

[jtran]

Hmm I think we rather want to prevent the element from getting autofocus, autocomplete may still be useful.

IMHO, the dropdown is a custom implementation of autocomplete. Having both a custom implementation and the browser's is conflicting. On the compare/New Pull Request page, you can select a branch by using the arrow keys to navigate the dropdown. Unfortunately, the branch selector in this pull request uses a separate implementation and doesn't have the cursor movement functionality. But presumably, they'll get unified at some point.

Anyway, for what it's worth, I think this is a good change.

[silverwind]

I can't seem to reproduce the original issue, whatever I do, it won't show any dropdown over the input. Tested in Firefox 89 and Chromium 90.

[jtran]

For me, the browser's autocomplete shows in Firefox 88.0.1 if I click on the input, after it already has the focus. So the steps are: click the branch selector (the dropdown should open and the input should have the focus), then click the input. I don't know if there are other ways to trigger it.

[zeripath]

I can't seem to reproduce the original issue, whatever I do, it won't show any dropdown over the input. Tested in Firefox 89 and Chromium 90.

I can reliably reproduce the issue and my PR fixes the issue.

[silverwind]

So the steps are: click the branch selector (the dropdown should open and the input should have the focus), then click the input.

Strange, doing that in Firefox 89 on Mac just brings up the browser-native dropdown menu with a input history, which I don't find too distracting. This behaviour might actually be platform-dependant.

[jtran]

Strange, doing that in Firefox 89 on Mac just brings up the browser-native dropdown menu with a input history...

I could be mistaken, but I thought that's what this issue is. My browser input history is short, so it doesn't look like the issue screenshot, but if it were longer, I think it would be the same. I'm also running on mac.

[zeripath]

Yes that is the problem - it very much gets in the way, you can't get rid of it, it's inconsistent with the rest of the drop-downs and it's really quite unhelpful.

[silverwind]

It doesn't bother me really and it's very hard to accidentially trigger it but I guess it is the correct solution to hide it.