Add primary key and index to external login user table #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created migration this way as there is no way to add primary key on existing table in sqlite3, at least I did not found it |
tboerger
added
the
lgtm/need 2
lunny
reviewed
May 2, 2017
| LoginSourceID int64 `xorm:"NOT NULL"` | ||
| ExternalID string `xorm:"pk NOT NULL"` | ||
| UserID int64 `xorm:"INDEX NOT NULL"` | ||
| LoginSourceID int64 `xorm:"pk NOT NULL"` |
There was a problem hiding this comment.
So one external user could be only linked to one internal user?
|
Yes, I think so. When authorizing with external user how would otherwise we know to what internal user to login otherwise. I think I did see error message about it somewhere when translating |
|
LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
May 2, 2017
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1655
I don't know if that's the best way for migration, it would be better to add primary key as SQL commands not recreating table, let me know what you think.