Skip to content

Improve resource string #16691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2021
Merged

Improve resource string #16691

merged 3 commits into from
Aug 14, 2021

Conversation

delvh
Copy link
Member

@delvh delvh commented Aug 14, 2021

Following a discussion on Crowdin, I rewrote this string into a more understandable description.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 14, 2021
@6543 6543 added modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 14, 2021
@6543 6543 added this to the 1.16.0 milestone Aug 14, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2021

Codecov Report

Merging #16691 (24ebe0f) into main (74d75eb) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16691      +/-   ##
==========================================
- Coverage   45.40%   45.38%   -0.03%     
==========================================
  Files         758      758              
  Lines       85306    85306              
==========================================
- Hits        38735    38716      -19     
- Misses      40291    40309      +18     
- Partials     6280     6281       +1     
Impacted Files Coverage Δ
modules/queue/workerpool.go 53.05% <0.00%> (-4.20%) ⬇️
services/pull/temp_repo.go 30.76% <0.00%> (-3.85%) ⬇️
services/pull/check.go 25.51% <0.00%> (-2.76%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
modules/git/blame.go 67.14% <0.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d75eb...24ebe0f. Read the comment docs.

@6543 6543 merged commit d17f555 into go-gitea:main Aug 14, 2021
@delvh delvh deleted the b/improved-resource-string branch August 14, 2021 14:16
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants