Skip to content

gofmt #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2017
Merged

gofmt #1710

merged 1 commit into from
May 12, 2017

Conversation

ethantkoenig
Copy link
Member

Run make fmt.

Sorry if this is nitpicky, but in development it would be convenient to run make fmt on my working changes without causing a bunch of changes elsewhere in the codebase.

@appleboy
Copy link
Member

@ethantkoenig Maybe we can wait for #1366 PR?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 12, 2017
@ethantkoenig
Copy link
Member Author

ethantkoenig commented May 12, 2017 •
edited
Loading

@appleboy This is (part of) the reason the build for #1366 is failing

@sapk
Copy link
Member

sapk commented May 12, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 12, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2017
@appleboy appleboy merged commit 9e627af into go-gitea:master May 12, 2017
@ethantkoenig ethantkoenig deleted the fmt branch May 12, 2017 14:45
@lunny lunny added this to the 1.2.0 milestone May 12, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 25, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @appleboy @sapk @lunny @tboerger