Migrate Description #17626 #17692
Merged
Migrate Description #17626 #17692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
Nov 17, 2021
GiteaBot
added
the
lgtm/need 2
99rgosse
force-pushed
the
migrate-description
branch
from
6582974 to
a2346e0
Compare
|
Sorry I may have made a mistake when force pushing to the branch, I did not see you added things. Please tell me if I have to change anything |
Yes, you should rebase the latest main branch. Or you can create a new PR. |
99rgosse
force-pushed
the
migrate-description
branch
from
a2346e0 to
232b800
Compare
lunny
approved these changes
Nov 18, 2021
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Nov 18, 2021
GiteaBot
added
lgtm/done
|
make L-G-T-M work |
|
Please send backport to v1.15 |
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Co-authored-by: 6543 <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the parameter for migrating the description of a repository : solves #17626
Actual behavior is opts.Description is only taken in account
I had to modify services/migrations/gitea_uploader.go too as the parameter wasn't modified if not a set one.
Tested okay on latest dev