Skip to content

Enable deprecation error for v1.17.0 #18341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Enable deprecation error for v1.17.0 #18341

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b92fb2
Enable deprecation error for v1.17.0
Jan 20, 2022
e6447be
Merge branch 'main' into enable-warning-notice
Jan 20, 2022
2f1747f
Do some more deprecations and add common comment // FIXME: DEPRECATION
zeripath Jan 20, 2022
1c7060e
Merge pull request #1 from zeripath/enable-warning-notice
Jan 20, 2022
e07a2ed
Merge branch 'main' into enable-warning-notice
techknowlogick Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/setting/mirror.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func newMirror() {
// - please note this was badly named and only disabled the creation of new pull mirrors
if Cfg.Section("repository").Key("DISABLE_MIRRORS").MustBool(false) {
log.Warn("Deprecated DISABLE_MIRRORS config is used, please change your config and use the options within the [mirror] section")
// TODO: enable on v1.17.0: log.Error("Deprecated fallback used, will be removed in v1.18.0")
log.Error("Deprecated fallback used, will be removed in v1.18.0")
Mirror.DisableNewPull = true
}
if err := Cfg.Section("mirror").MapTo(&Mirror); err != nil {
Expand Down