Skip to content

Remove annoying difference in button heights. #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2017
Merged

Conversation

SanPilot
Copy link
Contributor

@SanPilot SanPilot commented Jun 1, 2017

Why was that even there?

See before & after: http://imgur.com/a/yKdUR

Why was that even there?

See before & after: http://imgur.com/a/yKdUR
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jun 2, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 2, 2017
@appleboy
Copy link
Member

appleboy commented Jun 2, 2017

Please chage the less file not css.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 2, 2017
@SanPilot
Copy link
Contributor Author

SanPilot commented Jun 2, 2017

Okay. Updated my pull request.

@appleboy
Copy link
Member

appleboy commented Jun 2, 2017

@SanPilot Just change the less file. You don't need to change CSS file. Otherwise LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 2, 2017
@SanPilot
Copy link
Contributor Author

SanPilot commented Jun 2, 2017

I'm a little confused; will less be compiled in ci?

@appleboy
Copy link
Member

appleboy commented Jun 2, 2017

@SanPilot Your are right. 👍

@SanPilot
Copy link
Contributor Author

SanPilot commented Jun 2, 2017

Ok, I'll fix it in the morning.

@appleboy
Copy link
Member

appleboy commented Jun 2, 2017

@SanPilot No. You don't need to change anything. I say you are right for CI doesn't compile less file

@lafriks
Copy link
Member

lafriks commented Jun 2, 2017

Blue buttons height is still 1px too much, see:
attels

@sapk
Copy link
Member

sapk commented Jun 2, 2017

LGTM for at least have the same position. Like @lafriks show, blue buttons are larger than the url and can be fixed.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 2, 2017
@silverwind
Copy link
Member

Took a look at the CSS. It's not obvious what causes the different height and there are a number of padding hacks in place, especially for the clone bar. While the ideal solution would be to refactor the hacks to Semantic UI classes, a 7.5px padding on the buttons works on my screen.

@lunny
Copy link
Member

lunny commented Jun 3, 2017

@silverwind that maybe another PR. Let's merge this at first.

@lunny lunny merged commit 009a073 into go-gitea:master Jun 3, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants