-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Remove annoying difference in button heights. #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why was that even there? See before & after: http://imgur.com/a/yKdUR
Please chage the |
Okay. Updated my pull request. |
Pull from upstream
@SanPilot Just change the less file. You don't need to change CSS file. Otherwise LGTM |
I'm a little confused; will less be compiled in ci? |
@SanPilot Your are right. 👍 |
Ok, I'll fix it in the morning. |
@SanPilot No. You don't need to change anything. I say you are right for |
LGTM for at least have the same position. Like @lafriks show, blue buttons are larger than the url and can be fixed. |
Took a look at the CSS. It's not obvious what causes the different height and there are a number of padding hacks in place, especially for the clone bar. While the ideal solution would be to refactor the hacks to Semantic UI classes, a 7.5px padding on the buttons works on my screen. |
@silverwind that maybe another PR. Let's merge this at first. |
Why was that even there?
See before & after: http://imgur.com/a/yKdUR