Skip to content

Set Setpgid on child git processes #19865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 3, 2022
Merged

Set Setpgid on child git processes #19865

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b2584a2
Set Setpgid on child git processes
zeripath Jun 1, 2022
dfaff61
OK windows does not have this
zeripath Jun 1, 2022
e4b90e2
oops
zeripath Jun 1, 2022
d82bd95
try to get the go:build to work properly
zeripath Jun 1, 2022
5b7f201
Update modules/git/command_windows.go
zeripath Jun 1, 2022
4dc3c63
Apply suggestions from code review
techknowlogick Jun 1, 2022
5d1941e
Apply suggestions from code review
zeripath Jun 1, 2022
c6f274f
Merge branch 'main' into set-pgid-on-child-processes
jolheiser Jun 2, 2022
fd060fa
Extend to all other uses of CommandContext
zeripath Jun 2, 2022
0eabaf3
Merge branch 'main' into set-pgid-on-child-processes
zeripath Jun 3, 2022
4498295
Update modules/process/manager_unix.go
zeripath Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/git/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ func (c *Command) Run(opts *RunOpts) error {
"GIT_NO_REPLACE_OBJECTS=1",
)

setSysProcAttribute(cmd)
cmd.Dir = opts.Dir
cmd.Stdout = opts.Stdout
cmd.Stderr = opts.Stderr
Expand Down
16 changes: 16 additions & 0 deletions modules/git/command_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Copyright 2016 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.

//go:build !windows

package git

import (
"os/exec"
"syscall"
)

func setSysProcAttribute(cmd *exec.Cmd) {
cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
}
15 changes: 15 additions & 0 deletions modules/git/command_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2016 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.

//go:build windows

import (
"os/exec"
)

package git

func setSysProcAttribute(cmd *exec.Cmd) {
// Do nothing
}