Important: wrong PR merge commit ID saved #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any integration test? |
tboerger
added
the
lgtm/need 2
|
LGTM |
tboerger
added
lgtm/need 1
|
@lunny Since this is a model it would make more sense to have a UnitTest... Integration tests are mainly for End-To-End (web routes...) |
|
but LGTM |
tboerger
added
lgtm/done
|
integration test for #1994 will cover this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging PR changes that were made from forked repository last commit ID is taken from fork not base repository but for target branch, so it will point to wrong commit ID