wip: API for projects and boards #20208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshsalunke
changed the title
Gusted
added
type/feature
- Given we use go1.18 for this and don't rely on the Go 1.11 modules behavior(we use the modern `go run` & `go get` which has the correct behavior by-default).
The current `admin auth` CLI for managing authentication source of type LDAP via BindDN and Simple LDAP does not allow enabling the respective source, once disabled via `--not-active`. The same applies to `--synchronize-users` specifially for LDAP via BindDN. These changes add two new flags to LDAP related CLI commands: - `--active` for both LDAP authentication source types - `--disable-synchronize-users` for LDAP via BindDN Signed-off-by: justusbunsi <[email protected]>
The recent changes to add live-reloading to the i18n translation files made the i18n code totally non-concurrent when using dev. This will make discovering other concurrency related issues far more difficult. This PR fixes these, adds some more comments to the code and slightly restructures a few functions. Signed-off-by: Andrew Thornton <[email protected]>
* tests: integration tests for the Gitea migration form * use a mix of ` and " instead of backslash go-gitea#20121 (comment) Co-authored-by: Loïc Dachary <[email protected]>
* Adjust template for go-gitea#20069 smallbell * Adjust notification Unread Count variable to global and count bell position with mobile * Adjust bell icon style * Adjust smallbell to middle * Avoid using inline styles * move notificationUnreadCount to a general code block, reduce changed lines * Solved conflicts Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: 6543 <[email protected]>
…ea#20236) * Adjust class for mobile has the problem of double small bells * Update templates/base/head_navbar.tmpl Co-authored-by: Gusted <[email protected]> Co-authored-by: Gusted <[email protected]>
The setting `DEFAULT_SHOW_FULL_NAME` promises to use the user's full name everywhere it can be used. Unfortunately the function `*user_model.User.ShortName()` currently uses the `.Name` instead - but this should also use the `.FullName()`. Therefore we should make `*user_model.User.ShortName()` base its pre-shortened name on the `.FullName()` function.
Adjust the max-widths for the repository file table to allow for nicer resizing of the names and commit messages. Fix go-gitea#20040 Signed-off-by: Andrew Thornton <[email protected]> ## Screenshots ## MediaXL  ## MediaLg  ## MediaMd  ## MediaSm 
* go-gitea#20240 At the moment, Firefox (iOS) (10x) has an engine bug. See go-gitea#20240 If a script inserts a newly created (and content changed) element into DOM, there will be a nonsense error event reporting: Script error: line 0, col 0. This PR ignores such nonsense error event. Fix go-gitea#20240
- Initialize the popup for the tooltip inside the new code comment. - This works and is good enough to have this issue fixed for 1.17 Fix go-gitea#20068
Users who are following or being followed by a user should only be displayed if the viewing user can see them. Signed-off-by: Andrew Thornton <[email protected]>
The uid provided to the group filter must be properly escaped using the provided ldap.EscapeFilter function. Fix go-gitea#20181 Signed-off-by: Andrew Thornton <[email protected]>
Bumps [mermaid](https://github.com/knsv/mermaid) from 9.1.1 to 9.1.2. - [Release notes](https://github.com/knsv/mermaid/releases) - [Changelog](https://github.com/mermaid-js/mermaid/blob/develop/CHANGELOG.md) - [Commits](mermaid-js/mermaid@9.1.1...9.1.2) --- updated-dependencies: - dependency-name: mermaid dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The use of `m-4 text black` for the notification bell results in this icon being shifted upwards. Instead we should use the `item` class but adjust `not-mobile` and `mobile-only` to make their `display: none` settings `!important`. (As an aside: This is probably one of the only times we should use `!important` in our less files and the rest should be avoided or removed.) Ref go-gitea#20069 Revert go-gitea#20236 Signed-off-by: Andrew Thornton <[email protected]>
Unfortunately it appears that 2048 bit RSA keys can occasionally be created in such a way that they appear to have 2047 bit length. This PR simply changes our defaults to allow these. Fix go-gitea#20249 Signed-off-by: Andrew Thornton <[email protected]>
Unfortunately there is a bug in go-gitea#20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <[email protected]>
Milestone search keywords are now sensitive, this modification is changed to insensitive
- This code is only valid when `refNumeric` exist(otherwise we didn't find such numeric PR and can skip that check) and give a free-pas to the "BEFORE" check when `ref` is nil. - Resolves go-gitea#20109
* Add label to repo icons in explore page Co-authored-by: silverwind <[email protected]>
* Add git.HOME_PATH * add legacy file check * Apply suggestions from code review Co-authored-by: zeripath <[email protected]> * pass env GNUPGHOME to git command, move the existing .gitconfig to new home, make the fix for 1.17rc more clear. * set git.HOME_PATH for docker images to default HOME * Revert "set git.HOME_PATH for docker images to default HOME" This reverts commit f120101. * force Gitea to use a stable GNUPGHOME directory * extra check to ensure only process dir or symlink for legacy files * refactor variable name * The legacy dir check (for 1.17-rc1) could be removed with 1.18 release, since users should have upgraded from 1.17-rc to 1.17-stable * Update modules/git/git.go Co-authored-by: Steven Kriegler <[email protected]> * remove initFixGitHome117rc * Update git.go * Update docs/content/doc/advanced/config-cheat-sheet.en-us.md Co-authored-by: zeripath <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: Steven Kriegler <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Support synchronizing with the push mirrors whenever new commits are pushed or synced from pull mirror. Related Issues: go-gitea#18220 Co-authored-by: delvh <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
|
@6543 I have moved the methods into its own packages and also added new endpoints can you do a quick check on it and its ok then I will move forward with updating all the routes accordingly |
…into projects-api
dineshsalunke
changed the title
…into projects-api
|
Any progress? I can help you with writing tests or something. It's been a really old PR. |
|
@lng2020 Sorry for the delay, at my work we are closing on private alpha of our project so was too busy with that.
I would be more than happy feel free to add things as you feel.
honestly, I was thinking of the same thing its just that I didn't wanted history to repeat itself :D so I am thinking of working on finishing up the major stuff in here itself and then once we are in good position then we can close this and raise a new PR. |
|
@lng2020 If you don't mind me asking, what do you plan on using these changes for ? I mean do you wanna integrate something with gitea in terms of projects and issues ? |
Nothing particular. I'm just thrilled to see Gitea become more and more complete. |
9 tasks
|
Closing this in favor of #28111 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14299
This is my first jab at anything in go lang, so please bear with me if you notice some mistakes for time being.