Skip to content

Missing signed commit display translations #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Missing signed commit display translations #2134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions options/locale/locale_en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,8 @@ commits.message = Message
commits.date = Date
commits.older = Older
commits.newer = Newer
commits.signed_by = Signed by
commits.gpg_key_id = GPG key ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this one used in this PR, was it missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkcsoft fixed, I was testing if it works correctly and doing undo/redo and forgot to save latest code changes in editor :)


ext_issues = Ext Issues
ext_issues.desc = Ext Issues link to an external issue management page
Expand Down
4 changes: 2 additions & 2 deletions templates/repo/diff/page.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
{{if .Verification.Verified }}
<div class="ui bottom attached positive message" style="text-align: initial;color: black;">
<i class="green lock icon"></i>
<span style="color: #2C662D;">Signed by :</span>
<span style="color: #2C662D;">{{.i18n.Tr "repo.commits.signed_by"}}:</span>
<a href="{{.Verification.SigningUser.HomeLink}}"><strong>{{.Commit.Committer.Name}}</strong></a> <{{.Commit.Committer.Email}}>
<span class="pull-right"><span style="color: #2C662D;">GPG key ID:</span> {{.Verification.SigningKey.KeyID}}</span>
<span class="pull-right"><span style="color: #2C662D;">{{.i18n.Tr "repo.commits.gpg_key_id"}}:</span> {{.Verification.SigningKey.KeyID}}</span>
</div>
{{else}}
<div class="ui bottom attached message" style="text-align: initial;color: black;">
Expand Down