Skip to content

Fix bare-repo bugs #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2017
Merged

Fix bare-repo bugs #2199

merged 3 commits into from
Jul 27, 2017

Conversation

ethantkoenig
Copy link
Member

Check if that repo is not bare for the following endpoints:

  • :owner/:repo/commits
  • :owner/:repo/raw/*
  • :owner/:repo/commit/:sha
  • :owner/:repo/graph

Previously, accessing these endpoints with a bare repo resulted in a 500.

@ethantkoenig ethantkoenig changed the title Check if repo is bare Fix bare-repo bugs Jul 22, 2017
@lafriks
Copy link
Member

lafriks commented Jul 22, 2017

Integration tests for this would be nice

@lafriks lafriks added this to the 1.2.0 milestone Jul 22, 2017
@lafriks lafriks added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 22, 2017
@andreynering
Copy link
Contributor

LGTM

@lafriks lafriks added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 23, 2017
@Bwko
Copy link
Member

Bwko commented Jul 23, 2017

LGTM

@lafriks lafriks added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 23, 2017
@lunny
Copy link
Member

lunny commented Jul 26, 2017

please force empty push

@lunny
Copy link
Member

lunny commented Jul 26, 2017

Maybe some tests? @ethantkoenig

@ethantkoenig
Copy link
Member Author

@lunny @lafriks Added tests

@lafriks
Copy link
Member

lafriks commented Jul 27, 2017

In test there is unused import

@lafriks
Copy link
Member

lafriks commented Jul 27, 2017

LGTM

@lafriks lafriks merged commit fd45a03 into go-gitea:master Jul 27, 2017
@ethantkoenig ethantkoenig deleted the fix/bare_repo branch July 28, 2017 03:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants