Revert "Remove fomantic image module (#21145)" #22952
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit afdab9d.
|
Can we just selectively restore the CSS rules that fix the cases instead? We aim to remove Fomantic, this gets us further from that. Anyways, landing this is better than leaving it broken. |
GiteaBot
added
the
lgtm/need 2
|
I do not think you need to do this. The misalignment could be fixed by fine-tuned CSS styles. |
|
Yeah, I think I can fix the misalignment by tuning CSS rather than revert. I will close this PR and open another PR to fix it. |
|
You can put the rules in https://github.com/go-gitea/gitea/blob/main/web_src/less/_base.less, near the other fomantic rules, maybe at line 662. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22818.
This reverts commit afdab9d.
Misalignments in #22818 could be fixed.