Skip to content

Add INTERNAL_TOKEN to integration .ini file #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

strk
Copy link
Member

@strk strk commented Aug 20, 2017

Avoids override of source file upon running make test-pgsql

Long story: settings.NewContext adds an INTERNAL_TOKEN if none
is found; the other ini files under integration/ all have an
INTERNAL_TOKEN

Avoids override of source file upon running `make test-pgsql`

Long story: settings.NewContext *adds* an INTERNAL_TOKEN if none
is found; the other ini files under integration/ all have an
INTERNAL_TOKEN
@lafriks
Copy link
Member

lafriks commented Aug 20, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 20, 2017
@lafriks lafriks added this to the 1.2.0 milestone Aug 20, 2017
@lunny
Copy link
Member

lunny commented Aug 21, 2017

@strk maybe you can also add token for test-sqlite and test-mysql ?

@lafriks
Copy link
Member

lafriks commented Aug 21, 2017

@lunny in sqlite.ini and mysql.ini they are already there

@lunny
Copy link
Member

lunny commented Aug 21, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2017
@lunny lunny merged commit 951c909 into go-gitea:master Aug 21, 2017
@strk strk deleted the no-override-sources branch August 22, 2017 17:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants