Skip to content

Fix dropdown menu position when explore repos #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2017

Conversation

mul14
Copy link
Contributor

@mul14 mul14 commented Oct 31, 2017

This will fix the dropdown position when explore the repos.

Before

before

After

after

Signed-off-by: Mulia Arifandi Nasution <[email protected]>
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 31, 2017
@lunny lunny added this to the 1.x.x milestone Oct 31, 2017
@lafriks
Copy link
Member

lafriks commented Oct 31, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 31, 2017
@lafriks lafriks modified the milestones: 1.x.x, 1.3.0 Oct 31, 2017
@codecov-io
Copy link

codecov-io commented Oct 31, 2017

Codecov Report

Merging #2808 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2808   +/-   ##
=======================================
  Coverage   26.85%   26.85%           
=======================================
  Files          89       89           
  Lines       17600    17600           
=======================================
  Hits         4727     4727           
  Misses      12187    12187           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605038d...7852ca0. Read the comment docs.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2017
@lafriks
Copy link
Member

lafriks commented Oct 31, 2017

Make LG-TM work

@lafriks lafriks merged commit e225497 into go-gitea:master Oct 31, 2017
@mul14 mul14 deleted the explore-repo-dropdown-menu-position branch October 31, 2017 21:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants