Skip to content

Remove jQuery class from the image diff #30140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 29, 2024
Merged

Remove jQuery class from the image diff #30140

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e50df48
Remove jQuery class from the image diff
yardenshoham Mar 27, 2024
69982e1
Fix if
yardenshoham Mar 27, 2024
a867afb
Apply suggestions from code review
yardenshoham Mar 27, 2024
f906716
Use :scope
yardenshoham Mar 28, 2024
a59b533
Fix `this`
yardenshoham Mar 28, 2024
bc71d8b
Merge branch 'main' into imagediff-jquery-class
yardenshoham Mar 28, 2024
dfd8ca8
Merge branch 'main' into imagediff-jquery-class
yardenshoham Mar 29, 2024
ecb3b1c
Make it singular
yardenshoham Mar 29, 2024
7e657f3
Rename el to container
yardenshoham Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions web_src/js/features/imagediff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ export function initImageDiff() {
initOverlay(createContext($imagesAfter[2], $imagesBefore[2]));
}

$container.find('> .image-diff-tabs').removeClass('is-loading');
for (const el of Array.from(this.children).filter((child) => child.classList.contains('image-diff-tabs'))) {
el.classList.remove('is-loading');
}

function initSideBySide(sizes) {
let factor = 1;
Expand All @@ -126,13 +128,24 @@ export function initImageDiff() {

const widthChanged = sizes.$image1.length !== 0 && sizes.$image2.length !== 0 && sizes.$image1[0].naturalWidth !== sizes.$image2[0].naturalWidth;
const heightChanged = sizes.$image1.length !== 0 && sizes.$image2.length !== 0 && sizes.$image1[0].naturalHeight !== sizes.$image2[0].naturalHeight;
if (sizes.$image1.length !== 0) {
$container.find('.bounds-info-after .bounds-info-width').text(`${sizes.$image1[0].naturalWidth}px`).addClass(widthChanged ? 'green' : '');
$container.find('.bounds-info-after .bounds-info-height').text(`${sizes.$image1[0].naturalHeight}px`).addClass(heightChanged ? 'green' : '');
if (sizes.$image1 && sizes.$image1.length !== 0) {
const boundsInfoAfterWidth = this.querySelector('.bounds-info-after .bounds-info-width');
boundsInfoAfterWidth.textContent = `${sizes.$image1[0].naturalWidth}px`;
boundsInfoAfterWidth.classList.add(widthChanged ? 'green' : '');

const boundsInfoAfterHeight = this.querySelector('.bounds-info-after .bounds-info-height');
boundsInfoAfterHeight.textContent = `${sizes.$image1[0].naturalHeight}px`;
boundsInfoAfterHeight.classList.add(heightChanged ? 'green' : '');
}
if (sizes.$image2.length !== 0) {
$container.find('.bounds-info-before .bounds-info-width').text(`${sizes.$image2[0].naturalWidth}px`).addClass(widthChanged ? 'red' : '');
$container.find('.bounds-info-before .bounds-info-height').text(`${sizes.$image2[0].naturalHeight}px`).addClass(heightChanged ? 'red' : '');

if (sizes.$image2 && sizes.$image2.length !== 0) {
const boundsInfoBeforeWidth = this.querySelector('.bounds-info-before .bounds-info-width');
boundsInfoBeforeWidth.textContent = `${sizes.$image2[0].naturalWidth}px`;
boundsInfoBeforeWidth.classList.add(widthChanged ? 'red' : '');

const boundsInfoBeforeHeight = this.querySelector('.bounds-info-before .bounds-info-height');
boundsInfoBeforeHeight.textContent = `${sizes.$image2[0].naturalHeight}px`;
boundsInfoBeforeHeight.classList.add(heightChanged ? 'red' : '');
}

const image1 = sizes.$image1[0];
Expand Down