Skip to content

Remove jQuery class from the comment context menu #30179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 30, 2024
Merged

Remove jQuery class from the comment context menu #30179

merged 6 commits into from
Mar 30, 2024

Conversation

yardenshoham
Copy link
Member

@yardenshoham yardenshoham commented Mar 29, 2024 •
edited
Loading

  • Switched from jQuery class functions to plain JavaScript
  • Tested the comment context menu functionality and it works as before

@yardenshoham
Remove jQuery class from the comment context menu
6bd2bbe 
- Switched from jQuery class functions to plain JavaScript `classList`
- Tested the comment context menu functionality and it works as before

Signed-off-by: Yarden Shoham <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2024
silverwind
silverwind approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, batch a few more of these together, they are trivial changes.

@yardenshoham yardenshoham added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2024
@yardenshoham
Copy link
Member Author

I'm doing these file by file to make reviewing and testing easier

@silverwind
Copy link
Member

I'm doing these file by file to make reviewing and testing easier

Right, keep at it then. Makes it easier to deeper review the small changesets.

@silverwind silverwind self-requested a review March 29, 2024 20:17
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2024
@silverwind silverwind self-requested a review March 29, 2024 20:27
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2024
@silverwind silverwind merged commit 66f7d47 into go-gitea:main Mar 30, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 30, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2024
@yardenshoham yardenshoham deleted the dropdown-jquery-class branch March 30, 2024 09:41
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fb637f0 
* giteaofficial/main:
  Do not allow different storage configurations to point to the same directory (go-gitea#30169)
  Fix GPG subkey verify (go-gitea#30193)
  [skip ci] Updated translations via Crowdin
  Fix unclickable checkboxes (go-gitea#30195)
  Remove jQuery class from the issue author dropdown (go-gitea#30188)
  Remove jQuery class from the comment edit history (go-gitea#30186)
  Remove jQuery class from the repository branch settings (go-gitea#30184)
  [skip ci] Updated translations via Crowdin
  Use Crowdin action for translation sync (go-gitea#30054)
  Remove jQuery class from the project page (go-gitea#30183)
  Remove jQuery class from the comment context menu (go-gitea#30179)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yardenshoham @silverwind @delvh @wxiaoguang @GiteaBot