Add missed transaction on setmerged #33079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
If it is not a bug fix, then do not backport, and #33045 isn't backported. |
|
The missed transaction is a bug, it may result in dirty data in the database. I will backport this manually. |
delvh
reviewed
Jan 2, 2025
Zettat123
approved these changes
Jan 3, 2025
GiteaBot
added
lgtm/need 1
lunny
added a commit
that referenced
this pull request
Jan 6, 2025
backport from #33079 `SetMerged` should be in a database transaction otherwise it's possible to have dirty data.
wolfogre
approved these changes
Jan 8, 2025
GiteaBot
added
lgtm/done
wolfogre
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 10, 2025
* giteaofficial/main: Fix raw file API ref handling (go-gitea#33172) [skip ci] Updated translations via Crowdin Fix ACME panic (go-gitea#33178) Automerge supports deleting branch automatically after merging (go-gitea#32343) Fix branch dropdown not display ref name (go-gitea#33159) Add .run to gitignore (go-gitea#33175) Fix assignee list overlapping in Issue sidebar (go-gitea#33176) Fix pam auth test regression (go-gitea#33169) Move repo size to sidebar (go-gitea#33155) Fix fuzz test (go-gitea#33156) Refactor older tests to use testify (go-gitea#33140) [skip ci] Updated translations via Crowdin Fix typo in gitea downloader test and add missing codebase in `ToGitServiceType` (go-gitea#33146) Fix form width (go-gitea#33151) Convert github.com/xanzy/go-gitlab into gitlab.com/gitlab-org/api/client-go (go-gitea#33126) Refactor HTMLFormat, update chroma render, fix js error (go-gitea#33136) Add missed transaction on setmerged (go-gitea#33079)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #33045. There are two updates on
Set Merged, which should be in one transaction.This also introduced some refactors for changeissuestatus to make it more clear.