Skip to content

go1.24 #33562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 13, 2025
Merged

go1.24 #33562

merged 4 commits into from
Feb 13, 2025
+11 −11

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Feb 11, 2025 •
edited
Loading

update to use go1.24

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2025
@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Feb 12, 2025
@silverwind
Copy link
Member

silverwind commented Feb 13, 2025 •
edited
Loading

Can change in .devcontainer/devcontainer.json yet?

Edit: Apparently no: https://hub.docker.com/r/microsoft/devcontainers-go

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 13, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 13, 2025 09:59
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 13, 2025
@wxiaoguang wxiaoguang merged commit d88b012 into go-gitea:main Feb 13, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 13, 2025
@techknowlogick techknowlogick deleted the gobump branch February 13, 2025 14:29
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 14, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9c63998 
* giteaofficial/main:
  go1.24 (go-gitea#33562)
@yp05327
Copy link
Contributor

yp05327 commented Feb 24, 2025 •
edited
Loading

I'm using devcontainer and MS is not supported even now.
Then I need to modify go.mod back to 1.23 manually, or I can not develop or debug something .... :(

@kemzeb
Copy link
Member

kemzeb commented Mar 2, 2025

I'm using devcontainer and MS is not supported even now. Then I need to modify go.mod back to 1.23 manually, or I can not develop or debug something .... :(

FYI support for Go v1.24 was merged a couple of days ago (see here). They haven't published an image for it yet, but looking at their action workflows they seem to publish new images every month....? So I expect to see it published soon.

I should also note that they have a development image, dev-1.24-bookworm, that we can use in case that doesn't happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/internal topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@techknowlogick @silverwind @yp05327 @kemzeb @wxiaoguang @GiteaBot