Skip to content

Update JS and PY dependencies #33587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 16, 2025
Merged

Update JS and PY dependencies #33587

merged 8 commits into from
Feb 16, 2025

Conversation

silverwind
Copy link
Member

  • Update all dependencies excluding tailwindcss and idiomorph
  • Tested citation, asciinema, pdf, swagger

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 14, 2025
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 14, 2025
@silverwind
Copy link
Member Author

Playwright-related failure might be related, not sure. It does seem that go also crashes.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 14, 2025

Go panic is caused by e2e's failure.

Tested citation, asciinema, pdf, swagger

Maybe it could use e2e to test them (including katex and other markup rendering), then no need to manually test them again and again.

@silverwind
Copy link
Member Author

silverwind commented Feb 14, 2025

Yes indeed, but I also think e2e tests need a cleanup. I would like them to be without any go code. Just start the backend and run playwright. I'm not sure what the go code there actually achieves.

And this "screenshot" stuff needs to be nuked too, we don't do screenshots and it was only added in wishful thinking.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 14, 2025
@silverwind
Copy link
Member Author

Don't have time to investigate playwright now, so I've downgraded playwright and this should be mergable now.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2025
@silverwind silverwind merged commit 3bbacac into go-gitea:main Feb 16, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 16, 2025
@silverwind silverwind deleted the deps-88 branch February 16, 2025 13:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 17, 2025
* giteaofficial/main:
  Add API to support link package to repository and unlink it (go-gitea#33481)
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#33587)
  [chore] add git mailmap for proper attribution of authorship (go-gitea#33612)
  Move commits signature and verify functions to service layers (go-gitea#33605)
  add spacing between sign in button's icon and text (go-gitea#33609)
  enable literal string for code search (go-gitea#33590)
  [skip ci] Updated translations via Crowdin
  Artifacts download api for artifact actions v4 (go-gitea#33510)
  Fix bug when get commit (go-gitea#33602)
  Fix mirror bug (go-gitea#33597)
  Fix typo in HTML attribute (go-gitea#33599)
  Use default Git timeout when checking repo health (go-gitea#33593)
  Improve commits list performance to reduce unnecessary database queries (go-gitea#33528)
  Performance optimization for pull request files loading comments attachments (go-gitea#33585)
  Fix PR's target branch dropdown (go-gitea#33589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/frontend modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants