Skip to content

Refactor mail code #33768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Refactor mail code #33768

merged 2 commits into from
Mar 3, 2025

Conversation

wxiaoguang
Copy link
Contributor

mail.go contains various different functions, it's time to split it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 2, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 2, 2025
@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed modifies/go Pull requests that update Go code labels Mar 2, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 2, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 2, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 3, 2025 03:16
@wxiaoguang wxiaoguang merged commit 02657e8 into go-gitea:main Mar 3, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-mail branch March 3, 2025 03:45
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 3, 2025
* giteaofficial/main:
  Disable `vet` as part of `go test` (go-gitea#33662)
  Refactor error system (go-gitea#33771)
  Add migrations and doctor fixes (go-gitea#33556)
  Refactor mail code (go-gitea#33768)
  Refactor global init code and add more comments (go-gitea#33755)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants