Skip to content

remove context from mail struct #33811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Conversation

TheFox0x7
Copy link
Contributor

@TheFox0x7 TheFox0x7 commented Mar 6, 2025

it can be passed by argument instead


pending adding some more tests to improve coverage Done. Not the greatest but it's something.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 6, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 6, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 6, 2025
@TheFox0x7 TheFox0x7 force-pushed the remove-mail-context branch from 67618fa to 2b642aa Compare March 6, 2025 18:28
@TheFox0x7 TheFox0x7 marked this pull request as ready for review March 6, 2025 18:46
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 6, 2025
@lunny lunny enabled auto-merge (squash) March 6, 2025 18:59
@lunny lunny merged commit e7cf62f into go-gitea:main Mar 6, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 6, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 6, 2025
@TheFox0x7 TheFox0x7 deleted the remove-mail-context branch March 6, 2025 22:58
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 7, 2025
* giteaofficial/main:
  Use correct start and end commits for GetDiffTree (go-gitea#33816)
  Try to fix ACME (3rd) (go-gitea#33807)
  remove context from mail struct (go-gitea#33811)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants