Skip to content

Do not call "git diff" when listing PRs #33817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2025
Merged

Do not call "git diff" when listing PRs #33817

merged 3 commits into from
Mar 8, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #31492

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 7, 2025
@GiteaBot GiteaBot added this to the 1.23.6 milestone Mar 7, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 7, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 7, 2025
@wxiaoguang wxiaoguang mentioned this pull request Mar 7, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 7, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 8, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 8, 2025 07:19
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Mar 8, 2025 •
edited
Loading

The one for main branch is still pending. Decouple diff stats query from actual diffing #33810

@wxiaoguang wxiaoguang merged commit 869ee4f into go-gitea:release/v1.23 Mar 8, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-pr-list-diff branch March 8, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.23.6
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @hiifong @GiteaBot