Do not show passkey on http sites #33820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
backport/done
lunny
approved these changes
Mar 7, 2025
GiteaBot
added
lgtm/need 1
ChristopherHX
approved these changes
Mar 7, 2025
GiteaBot
added
lgtm/done
lafriks
pushed a commit
that referenced
this pull request
Mar 7, 2025
* Backport #33348 * Backport #33820 --------- Co-authored-by: yp05327 <[email protected]>
lafriks
approved these changes
Mar 7, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 10, 2025
* giteaofficial/main: Move notifywatch to service layer (go-gitea#33825) [skip ci] Updated translations via Crowdin Only keep popular licenses (go-gitea#33832) Removing unwanted ui container (go-gitea#33833) Full-file syntax highlighting for diff pages (go-gitea#33766) Improve theme display (go-gitea#30671) Decouple context from repository related structs (go-gitea#33823) Improve log format (go-gitea#33814) Decouple diff stats query from actual diffing (go-gitea#33810) Add global lock for migrations to make upgrade more safe with multiple replications (go-gitea#33706) Do not show passkey on http sites (go-gitea#33820)
hiifong
pushed a commit
to hiifong/gitea
that referenced
this pull request
Mar 10, 2025
Fix go-gitea#33615 (cherry picked from commit b8c2afd)
silverwind
reviewed
Mar 16, 2025
| hideElem(elSignInPasskeyBtn); | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
Just because I didn't know it
There was a problem hiding this comment.
Care for a PR? I'm not sure I undertand the full context of this change.
There was a problem hiding this comment.
Feel free to open a PR
There was a problem hiding this comment.
As I said, I don't fully understand. Do you think window.location.protocol === 'http:' && !window.isSecureContext is the right condition?
There was a problem hiding this comment.
No idea, I think the old approach is quite trivial and won't cause any real problem. The time could be spent on something more important.
There was a problem hiding this comment.
Just replace the whole by
if (!window.isSecureContext) {
hideElem(elSignInPasskeyBtn);
return;
}
I have tested this and this seem to be equivalent.
There was a problem hiding this comment.
Thanks, that seems reasonable, I will open a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33615