Skip to content

Optimize total count of feed when loading activities in user dashboard. #33841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2025
Merged

Optimize total count of feed when loading activities in user dashboard. #33841

merged 6 commits into from
Mar 20, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 10, 2025 •
edited
Loading

Two SQLs are very slow when action table have over 5M records.

database duration=1.8881s db.sql="SELECT created_unix DIV 900 * 900 AS timestamp, count(user_id) as contributions FROM `action` WHERE user_id=? AND act_user_id=? AND (created_unix > ?) GROUP BY timestamp ORDER BY timestamp"

database duration=1.5408s db.sql="SELECT count(*) FROM `action` WHERE (user_id = ?) AND (is_deleted = ?)"

This will cache the count for the first loading or when the activities changed.

@lunny lunny added the performance/speed performance issues with slow downs label Mar 10, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Mar 10, 2025
@github-actions github-actions bot removed the modifies/api This PR adds API routes or modifies them label Mar 10, 2025
@delvh
Copy link
Member

delvh commented Mar 10, 2025

created_unix DIV 900 * 900

Wait what? Why is this query so weird in the first place?

@lunny
Copy link
Member Author

lunny commented Mar 10, 2025

created_unix DIV 900 * 900

Wait what? Why is this query so weird in the first place?

This was introduced by #15252

@lunny lunny added this to the 1.24.0 milestone Mar 11, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2025
@lunny lunny merged commit a4df01b into go-gitea:main Mar 20, 2025
26 checks passed
@lunny lunny deleted the lunny/optimaze_feed_count branch March 20, 2025 17:46
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 24, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fde02d1 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Only use prev and next buttons for pagination on user dashboard (go-gitea#33981)
  update jwt and redis packages (go-gitea#33984)
  [skip ci] Updated translations via Crowdin
  Improve oauth2 error handling (go-gitea#33969)
  [skip ci] Updated translations via Crowdin
  Cover `go.mod` and `go.sum` in `.editorconfig` (go-gitea#33960)
  Drop timeout for requests made to the internal hook api (go-gitea#33947)
  Fix file name could not be searched if the file was not a text file when using the Bleve indexer (go-gitea#33959)
  Fix oauth2 auth and UI (go-gitea#33961)
  Allow filtering issues by any assignee (go-gitea#33343)
  Optimize total count of feed when loading activities in user dashboard. (go-gitea#33841)
  Extract code to their own functions for push update (go-gitea#33944)
  Optimize heatmap query (go-gitea#33853)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code performance/speed performance issues with slow downs
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @delvh @appleboy @hiifong @GiteaBot