Skip to content

Optimize Layout Styles of Filelist #33920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 18, 2025
Merged

Optimize Layout Styles of Filelist #33920

merged 6 commits into from
Mar 18, 2025

Conversation

kerwin612
Copy link
Member

before:
cdaf1472fdae1b450c5313779394a37

after:
dce221fb61cc7bd3400f99e1877df08

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 17, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 18, 2025
@kerwin612 kerwin612 requested a review from wxiaoguang March 18, 2025 01:30
@wxiaoguang
Copy link
Contributor

The fix doesn't seem right. Please revert to the old styles and just add min-width: 0

@kerwin612
Copy link
Member Author

The fix doesn't seem right. Please revert to the old styles and just add min-width: 0

There are still some remaining issues with the old style that need to be addressed. In the latest commit, I resolved this problem. You can take a closer look at the latest commit.

old styles:
image

latest:
image

@kerwin612
Copy link
Member Author

tests repo: https://gitea.com/kerwin612/test

@wxiaoguang
Copy link
Contributor

I do not think the layout is right. Name is more important than commit ID

image

@kerwin612
Copy link
Member Author

I do not think the layout is right. Name is more important than commit ID

I think they are all important. However, in the screenshot you provided, the names are completely unreadable, which is obviously unreasonable. I believe it would be reasonable to add a minimum width to the column where the names are located.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 18, 2025 •
edited
Loading

I think they are all important.

Which one is more important?

In other words, when you read the hex commit ID, what you could get? It doesn't really mean anything to readers. Could you figure out the difference between commit ID "1a1a1a1" and "2b2b2b2"?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 18, 2025 •
edited
Loading

The fix doesn't seem right. Please revert to the old styles and just add min-width: 0

I would still suggest this one: revert to the first commit and just add min-width: 0, it should be good enough, no need to over-design.

@kerwin612
Copy link
Member Author

I think they are all important.

Which one is more important?

In other words, when you read the hex commit ID, what you could get? It doesn't really mean anything to readers. Could you figure out the difference between commit ID "1a1a1a1" and "2b2b2b2"?

It is not just a name, but also provides a hyperlink for users to quickly access a specific commit. I think since this entry is provided, Then, doesn't it inherently need to be displayed?

@kerwin612
Copy link
Member Author

I have commit a new version and fixed the issues you've provided feedback on. Of course, if you still prefer the first version, I can revert it as well.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 18, 2025
@wxiaoguang
Copy link
Contributor

Made some changes, use "entry-name" as class name, and remove some unnecessary CSS classes.

Does it look good to you?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 18, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2025
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 18, 2025
@lunny lunny added this to the 1.24.0 milestone Mar 18, 2025
@wxiaoguang wxiaoguang merged commit dcbf6c2 into go-gitea:main Mar 18, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the optimize-filelist-layout branch March 18, 2025 16:59
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 19, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
afce5d2 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Optimize Layout Styles of Filelist (go-gitea#33920)
  [skip ci] Updated translations via Crowdin
  update go version for devcontainers (go-gitea#33923)
  Added Description Field for Secrets and Variables  (go-gitea#33526)
  Try to figure out attribute checker problem (go-gitea#33901)
  Defer captcha script loading (go-gitea#33919)
  Fix file tree issues (go-gitea#33916)
  Remove unused or abused styles (go-gitea#33918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kerwin612 @wxiaoguang @lunny @GiteaBot