Skip to content

Move ParseBool to optional #33979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 22, 2025

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 22, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 22, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 24, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 24, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) March 24, 2025 03:27
@techknowlogick techknowlogick added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 24, 2025
@techknowlogick techknowlogick merged commit 25b6f38 into go-gitea:main Mar 24, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 24, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 24, 2025
@lunny lunny deleted the lunny/move_optional_ParseBool branch March 24, 2025 05:05
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 26, 2025
* giteaofficial/main:
  Enable color output in govulncheck (go-gitea#34012)
  Update Makefile test comments (go-gitea#34013)
  Move duplicated functions (go-gitea#33977)
  Git client will follow 301 but 307 (go-gitea#34005)
  Prepare common tmpl functions in a middleware (go-gitea#33957)
  Update go mod dependencies (go-gitea#33988)
  Fix some migration and repo name problems (go-gitea#33986)
  [skip ci] Updated translations via Crowdin
  Use filepath.Join instead of path.Join for file system file operations (go-gitea#33978)
  Add changelog for 1.23.6 (go-gitea#33975)
  Fix incorrect code search indexer options (go-gitea#33992)
  Auto expand "New PR" form (go-gitea#33971)
  Move ParseBool to optional (go-gitea#33979)
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants