Skip to content

Add anonymous access support for private/unlisted repositories #34051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 28, 2025

Follow #33127

Fix #8649, fix #639

This is a complete solution. A repo unit could be set to:

  • Anonymous read (non-signed-in user)
  • Everyone read (signed-in user)
  • Everyone write (wiki-only)

Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/34051/files?diff=unified&w=1

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 28, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Mar 28, 2025
@wxiaoguang
Copy link
Contributor Author

image

@wxiaoguang wxiaoguang force-pushed the support-anonymous-access branch from 41ec8b7 to 4b2dfc0 Compare March 28, 2025 17:25
@wxiaoguang wxiaoguang added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 28, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 28, 2025
@lunny
Copy link
Member

lunny commented Mar 28, 2025

When review this pull request, I found the bug #34053 . An anonymous user who can view issue unit can also be impacted by that.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2025
@wxiaoguang wxiaoguang changed the title Add anonymous access support for private repositories Add anonymous access support for private/unlisted repositories Mar 29, 2025
@wxiaoguang wxiaoguang merged commit cddd19e into go-gitea:main Mar 29, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the support-anonymous-access branch March 29, 2025 05:26
@yp05327
Copy link
Contributor

yp05327 commented Mar 29, 2025

Maybe it's better to add a doc update label or the description in web ui about the difference between Anonymous read and
Everyone read. (It has been explained in the PR's description, but usually users will not check it)

-> #34057

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 31, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Add toggleClass function in dom.ts (go-gitea#34063)
  Add a config option to block "expensive" pages for anonymous users (go-gitea#34024)
  add additional ReplaceAll in pathsep to cater for different pathsep (go-gitea#34061)
  [skip ci] Updated translations via Crowdin
  enable staticcheck QFxxxx rules (go-gitea#34064)
  update to golangci-lint v2 (go-gitea#34054)
  Add descriptions for private repo public access settings and improve the UI (go-gitea#34057)
  Add anonymous access support for private/unlisted repositories (go-gitea#34051)
  Hide activity contributors, recent commits and code frequrency left tabs if there is no code permission (go-gitea#34053)
  Update action status badge layout (go-gitea#34018)
  Add anonymous access support for private repositories (backend) (go-gitea#33257)
  Simplify emoji rendering (go-gitea#34048)
  Adjust the layout of the toolbar on the Issues/Projects page (go-gitea#33667)
  Fix bug on downloading job logs (go-gitea#34041)
  Fix git client accessing renamed repo  (go-gitea#34034)
  Decouple Batch from git.Repository to simplify usage without requiring the creation of a Repository struct. (go-gitea#34001)
  fix org repo creation being limited by user limits (go-gitea#34030)
  Fix the issue with error message logging for the `check-attr` command on Windows OS. (go-gitea#34035)
  Try to fix check-attr bug (go-gitea#34029)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add unlisted repositories Public issue trackers and/or wikis for private repositories
6 participants