Cache GPG keys, emails and users when list commits #34086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
changed the title
lunny
changed the title
hiifong
reviewed
Apr 2, 2025
hiifong
approved these changes
Apr 2, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Apr 2, 2025
lunny
changed the title
yp05327
reviewed
Apr 7, 2025
wxiaoguang
reviewed
Apr 8, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
GiteaBot
added
lgtm/blocked
wxiaoguang
dismissed
their stale review
Hmm, maybe misread, will take a deep look
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Apr 8, 2025
wxiaoguang
reviewed
Apr 8, 2025
yp05327
approved these changes
Apr 9, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
YaFou
pushed a commit
to YaFou/gitea
that referenced
this pull request
Apr 9, 2025
When list commits, some of the commits authors are the same at many situations. But current logic will always fetch the same GPG keys from database. This PR will cache the GPG keys, emails and users for the context so that reducing the database queries. --------- Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When list commits, some of the commits authors are the same at many situations. But current logic will always fetch the same GPG keys from database. This PR will cache the GPG keys, emails and users for the context so that reducing the database queries.