Skip to content

Do not show 500 error when default branch doesn't exist #34096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

Do not show 500 error when default branch doesn't exist #34096

merged 3 commits into from
Apr 2, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #34090

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 2, 2025
@wxiaoguang
Copy link
Contributor Author

image

@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code labels Apr 2, 2025
@wxiaoguang wxiaoguang mentioned this pull request Apr 2, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 2, 2025
@wxiaoguang wxiaoguang added the backport/v1.23 This PR should be backported to Gitea 1.23 label Apr 2, 2025
lunny
lunny reviewed Apr 2, 2025
View reviewed changes
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 2, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 2, 2025
@lunny lunny merged commit 6ed1b26 into go-gitea:main Apr 2, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Apr 2, 2025
@GiteaBot
Copy link
Collaborator

GiteaBot commented Apr 2, 2025

I was unable to create a backport for 1.23. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 34096
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 2, 2025
@wxiaoguang wxiaoguang deleted the fix-default-branch-not-exist branch April 2, 2025 05:41
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Apr 2, 2025
@wxiaoguang
Do not show 500 error when default branch doesn't exist (go-gitea#34096)
2b4e2b4 
Fix go-gitea#34090
# Conflicts:
#	routers/web/repo/actions/actions.go
#	services/context/context_response.go
@wxiaoguang wxiaoguang mentioned this pull request Apr 2, 2025
Merged
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Apr 2, 2025
@wxiaoguang
Do not show 500 error when default branch doesn't exist (go-gitea#34096)
0ff29db 
Fix go-gitea#34090
# Conflicts:
#	routers/web/repo/actions/actions.go
#	services/context/context_response.go
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Apr 2, 2025
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Apr 2, 2025
@wxiaoguang
Do not show 500 error when default branch doesn't exist (go-gitea#34096)
84ca020 
Fix go-gitea#34090
# Conflicts:
#	routers/web/repo/actions/actions.go
#	services/context/context_response.go
wxiaoguang added a commit that referenced this pull request Apr 2, 2025
@wxiaoguang
Do not show 500 error when default branch doesn't exist (#34096) (#34097
8f75f61 
)

Backport #34096
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 3, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0958343 
* giteaofficial/main:
  Refactor Branch struct in package modules/git (go-gitea#33980)
  Support creating relative link to raw path in markdown (go-gitea#34105)
  Add new CLI flags to set name and scopes when creating a user with access token (go-gitea#34080)
  Do not show 500 error when default branch doesn't exist (go-gitea#34096)
  Return default avatar url when user id is zero rather than updating database (go-gitea#34094)
  [skip ci] Updated translations via Crowdin
  Fix return bug (go-gitea#34093)
  Move ParseCommitWithSSHSignature to service layer (go-gitea#34087)
  fix(i18n): clarify ownership in password change error messages (go-gitea#34092)
  Enable addtional linters (go-gitea#34085)
  Add flat-square action badge style (go-gitea#34062)
  Fix some UI bugs and clean up unused tests (go-gitea#34088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/translation
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

500 Internal Server Error @ http://192.168.128.136:3000/username/repository/activity
4 participants
@wxiaoguang @GiteaBot @lunny @hiifong