Add a --fullname arg to gitea admin user create. #34241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
lunny
approved these changes
Apr 18, 2025
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Apr 18, 2025
GiteaBot
added
lgtm/done
techknowlogick
added
type/enhancement
wxiaoguang
reviewed
Apr 19, 2025
GiteaBot
added
lgtm/done
wxiaoguang
reviewed
Apr 19, 2025
cmd/admin_user_create_test.go
Outdated
Comment on lines
121
to
125
| createUserN := func(name string, args []string) error { | ||
| cmd := []string{"./gitea", "admin", "user", "create", "--username", name, "--email", name + "@gitea.local"} | ||
| cmd = append(cmd, args...) | ||
| return app.Run(cmd) | ||
| } |
There was a problem hiding this comment.
It doesn't to test "space" behavior. You could just still use the old createUser
The "space" behavior is guaranteed by the shell CLI
There was a problem hiding this comment.
The string.Fields call in the old createUser doesn't allow for spaces in arguments so it can't be used here.
There was a problem hiding this comment.
It doesn't to test "space" behavior. You could just still use the old createUser
The "space" behavior is guaranteed by the shell CLI
There was a problem hiding this comment.
If you still prefer to test the space behavior, it's better to refactor the old "createUser" to support arguments:
createUser := func(name, args ...string) error {
return app.Run(append([]string{"./gitea", "admin", "user", "create", "--username", name, "--email", name + "@gitea.local"}, args...)...)
}
There was a problem hiding this comment.
I made some changes in 685d98a :
- Refactor
createUserto accept argument slice, then we can use it for general purpose, without duplicating code - Simplify the test cases, I think these 2 cases should be able to have a good coverage (same coverage as before)
Does it look good to you?
There was a problem hiding this comment.
Yes, that's definitely better, thank you!
There was a problem hiding this comment.
Thank you for the PR too! Will merge after CI passes.
hawicz
force-pushed
the
add-fullname-arg
branch
from
857a458 to
2f1dd3d
Compare
wxiaoguang
force-pushed
the
add-fullname-arg
branch
from
5f2aad7 to
685d98a
Compare
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 21, 2025
* giteaofficial/main: Add API routes to lock and unlock issues (go-gitea#34165) Make ROOT_URL support using request Host header (go-gitea#32564) Valid email address should only start with alphanumeric (go-gitea#28174) Fix notify watch failure when the content is too long (go-gitea#34233) Add "--fullname" arg to gitea admin user create (go-gitea#34241) Fix various UI problems (go-gitea#34243) markup: improve code block readability and isolate copy button (go-gitea#34009) Don't assume the default wiki branch is master in the wiki API (go-gitea#34244) [skip ci] Updated translations via Crowdin Optimize the calling code of queryElems (go-gitea#34235) Actions Runner rest api (go-gitea#33873) Fix some trivial problems (go-gitea#34237) Swift files can be passed either as file or as form value (go-gitea#34068) # Conflicts: # templates/repo/wiki/revision.tmpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.