Update branch_dropdown.tmpl #34278
Closed
Update branch_dropdown.tmpl #34278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
|
BTW we could likely render this "Compare" text into the placeholder so it does not flash empty on page load until the JS has loaded. Same technique should already be in use on branch dropdown on the repo page. |
done. |
wxiaoguang
reviewed
Apr 27, 2025
| {{end}} | ||
| <strong class="tw-ml-2 tw-inline-block gt-ellipsis">{{Iif .DropdownFixedText .SelectedRefShortName}}</strong> |
There was a problem hiding this comment.
The change is not ideal. The old bug was caused by incorrect Iif, it should be or
There was a problem hiding this comment.
Hmm, to match Vue, maybe the `if is better
|
Merge the changes into Fix button alignments #34276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitea/templates/repo/branch_dropdown.tmpl
Line 48 in e625250
before:
after:
