Skip to content

Use run-name and evaluate workflow variables #34301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
May 20, 2025
Merged

Use run-name and evaluate workflow variables #34301

merged 40 commits into from
May 20, 2025

Conversation

badhezi
Copy link
Contributor

@badhezi badhezi commented Apr 28, 2025 •
edited
Loading

This addresses #34247
depends on https://gitea.com/gitea/act/pulls/137

I couldn't find any previous implementation for run-name support on workflows so I created one.

Key points:
All dispatched workflows, scheduled workflows and detected workflows (from different hooks) will use and evaluate run-name if exists, with the corresponding gitea context and variables. This will be used as the Action run title and replace the default commit message being used today.

Had to change act package jobparser (see link above)
and create two helpers

gitea/models/actions/utils.go

Line 86 in 3a1320c

func (s *ActionSchedule) ToActionRun() *ActionRun {

and

gitea/services/actions/context.go

Line 169 in 3a1320c

func (g *GiteaContext) ToGitHubContext() *model.GithubContext {

to pass the correct types to GenerateGiteaContext and WithGitContext respectively.

Screenshot 2025-04-28 at 17 13 01

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/frontend labels Apr 28, 2025
@badhezi badhezi changed the title Dev/hezi/fix run name Use run-name and evaluate workflow variables Apr 28, 2025
@badhezi badhezi mentioned this pull request Apr 28, 2025
Closed
@TheFox0x7
Copy link
Contributor

Shouldn't this go to jobparser?

@badhezi
Copy link
Contributor Author

badhezi commented Apr 29, 2025

@TheFox0x7
Created https://gitea.com/gitea/act/pulls/136 to move most of the logic to jobparser

@badhezi badhezi force-pushed the dev/hezi/fix-run-name branch from cca335d to 9408c76 Compare April 29, 2025 12:17
@badhezi
Copy link
Contributor Author

badhezi commented May 12, 2025

Hey @lunny you think I can get someone to review https://gitea.com/gitea/act/pulls/137 so we can push this forward?
Thanks.

@lunny
Copy link
Member

lunny commented May 12, 2025 •
edited
Loading

Hey @lunny you think I can get someone to review https://gitea.com/gitea/act/pulls/137 so we can push this forward? Thanks.

That PR merged.

@badhezi
Copy link
Contributor Author

badhezi commented May 12, 2025

Hey @lunny you think I can get someone to review https://gitea.com/gitea/act/pulls/137 so we can push this forward? Thanks.

That PR merged.

Thanks @lunny
Should I want for a new tag release of gitea/act or is there anything else to do?

@lunny
Copy link
Member

lunny commented May 12, 2025

Hey @lunny you think I can get someone to review https://gitea.com/gitea/act/pulls/137 so we can push this forward? Thanks.

That PR merged.

Thanks @lunny Should I want for a new tag release of gitea/act or is there anything else to do?

v0.261.6 tagged.

chhe pushed a commit to chhe/act that referenced this pull request May 13, 2025
@badhezi @lunny
Evaluate run-name field for workflows (#137)
9924aea 
To support go-gitea/gitea#34301

Reviewed-on: https://gitea.com/gitea/act/pulls/137
Reviewed-by: Lunny Xiao <[email protected]>
Co-authored-by: badhezi <[email protected]>
Co-committed-by: badhezi <[email protected]>
@badhezi
Copy link
Contributor Author

badhezi commented May 13, 2025 •
edited
Loading

Can this PR please be reviewed?
@wxiaoguang @lunny
Thanks

@lunny lunny added this to the 1.25.0 milestone May 13, 2025
Zettat123
Zettat123 reviewed May 16, 2025
View reviewed changes
@badhezi badhezi requested a review from Zettat123 May 16, 2025 22:03
lunny
lunny reviewed May 16, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed May 17, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 17, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 19, 2025
@lunny lunny enabled auto-merge (squash) May 20, 2025 02:02
@lunny lunny merged commit 0534edd into go-gitea:main May 20, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 20, 2025
wxiaoguang
wxiaoguang reviewed May 20, 2025
View reviewed changes
@lunny lunny mentioned this pull request May 20, 2025
Merged
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 21, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
2549ad6 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix ephemeral runner deletion (go-gitea#34447)
  ui: add a default tab on repo header when migrating (go-gitea#34503)
  Use run-name and evaluate workflow variables (go-gitea#34301)
  feat(api): add date range filtering to commit retrieval endpoints (go-gitea#34497)
  Export repo's manual merge settings (go-gitea#34502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang left review comments

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
6 participants
@badhezi @TheFox0x7 @lunny @wxiaoguang @Zettat123 @GiteaBot