Add post-installation redirect based on admin account status #34493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
wxiaoguang
reviewed
May 17, 2025
wxiaoguang
reviewed
May 17, 2025
wxiaoguang
reviewed
May 17, 2025
kemzeb
reviewed
May 18, 2025
wxiaoguang
reviewed
May 18, 2025
| @@ -831,6 +831,21 @@ type CountUserFilter struct { | |||
| IsActive optional.Option[bool] | |||
| } | |||
|
|
|||
| // HasUsers returns true if any user exists in the database. | |||
| // It performs a much more efficient check than counting all users. | |||
| func HasUsers(ctx context.Context) (bool, error) { | |||
There was a problem hiding this comment.
It's better to make handleUserCreated use the same logic.
And there is no need to add "WHERE ...", just check whether any record exists.
There was a problem hiding this comment.
There is a key logic in handleUserCreated, which is to determine whether the current account is the first: CountUsers(ctx, nil) == 1; I am not quite sure if it can be replaced with the newly added method.
kemzeb
reviewed
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature to direct users to appropriate pages after system installation: