Skip to content

Add LDAP integration tests #3897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 11, 2018
Merged

Add LDAP integration tests #3897

merged 7 commits into from
May 11, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 5, 2018 •
edited
Loading

Test for adding LDAP (via BindDN) auth source, test if user can sign in with LDAP username and password, test for ldap user sync

@lafriks lafriks added pr/wip This PR is not ready for review type/testing labels May 5, 2018
@codecov-io
Copy link

codecov-io commented May 5, 2018 •
edited
Loading

Codecov Report

Merging #3897 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3897   +/-   ##
=======================================
  Coverage   20.27%   20.27%           
=======================================
  Files         146      146           
  Lines       29316    29316           
=======================================
  Hits         5945     5945           
  Misses      22470    22470           
  Partials      901      901

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aafb0ea...058e81d. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2018
@lafriks lafriks force-pushed the feat/test_ldap_auth branch 2 times, most recently from 19c21ec to 4dd1335 Compare May 5, 2018 02:31
@lafriks lafriks removed the pr/wip This PR is not ready for review label May 5, 2018
@lafriks lafriks added this to the 1.5.0 milestone May 5, 2018
@lafriks lafriks force-pushed the feat/test_ldap_auth branch from 4956e59 to e357a83 Compare May 5, 2018 21:33
@lunny
Copy link
Member

lunny commented May 11, 2018

conflicted

@lafriks
Copy link
Member Author

lafriks commented May 11, 2018

@lunny resolved

@lunny
Copy link
Member

lunny commented May 11, 2018

Trusted LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2018
@lunny
Copy link
Member

lunny commented May 11, 2018

make L-G-T-M

@lunny lunny merged commit ff3971b into go-gitea:master May 11, 2018
@lafriks lafriks deleted the feat/test_ldap_auth branch May 11, 2018 13:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @lunny @appleboy @bkcsoft