Fix comment box not showing on PR commit replies

[jamesa]

Fixes #5237

The form that gets revealed when clicking on the "Reply" button mentioned in #5237, and the button, do not share the same parent. The button ends up getting wrapped in a link which causes this issue.

I have no idea how or why this worked on the English translation though. Didn't dig in that deep. :)

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@e8b197d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5239   +/-   ##
=========================================
  Coverage          ?   37.39%           
=========================================
  Files             ?      312           
  Lines             ?    46313           
  Branches          ?        0           
=========================================
  Hits              ?    17317           
  Misses            ?    26517           
  Partials          ?     2479

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b197d...137116b. Read the comment docs.

[zeripath]

Hmm.. it's very interesting in the English translation the comment button appears in the following structure (This is presumably the case for every translation that works):

<div id="code-comments-...">
    <div class="ui comments">...</div>
    <button class="comment-form-reply ui green labeled icon tiny button">...</button>
    <form class="ui form hide comment-form comment-form-reply" action="..." method="post">...</form>
</div>

However, in the Spanish translation it becomes:

<div id="code-comments-X">
    <div class="ui comments">...</div>
    <a href="#issuecomment-X">
        <button class="comment-form-reply ui green labeled icon tiny button">...</button>
    </a>
    <form class="ui form hide comment-form comment-form-reply" action="..." method="post">...</form>
</div>

[zeripath]

OK I think that the locale-es_ES.ini file has a problem. There are likely other problems in that file too.

line 459:

...
issues.commented_at=`comentado <a href="#%s"> %s`</a>
...

is the cause of this issue. The backtick (`) before the </a> means that the <a href="..."> is never closed.

[jamesa]

Nice find! This might not be the best fix then. It works but it might not be the most efficient.

[techknowlogick]

Seems as though the translation files may be an issue. See: #5237 (comment)

[zeripath]

This PR is attempting to fix the problem in the wrong place. The issue lies in the locale file for Spanish and the problem should be fixed in the translation.

[jamesa]

If you guys are fine with it, I can use this PR to make those changes. Unless @zeripath you would like to, or if another PR should be raised for this issue.

[techknowlogick]

The translations should be done via crowdin, as otherwise they will be overwritten by crowdin.

[zeripath]

line 795: auths.tip.facebook also needs adjustment as it has an open double-quote.

[techknowlogick]

Closing as translation files have been updated.