Skip to content

tools: upgrade all tools to latest #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ linters-settings:
govet:
enable-all: true
check-shadowing: true
disable:
- fieldalignment
depguard:
list-type: blacklist
include-go-root: true
Expand Down Expand Up @@ -110,6 +112,7 @@ linters:
- paralleltest # paralleltest detects missing usage of t.Parallel() method in your Go test
- scopelint # Scopelint checks for unpinned variables in go programs
- sqlclosecheck # Checks that sql.Rows and sql.Stmt are closed
- wrapcheck # Checks that errors returned from external packages are wrapped TODO(zchee): enable
- wsl # Whitespace Linter
enable:
- asciicheck # Simple linter to check that your code does not contain non-ASCII identifiers
Expand All @@ -136,10 +139,8 @@ linters:
- govet # Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string
- ifshort # Checks that your code uses short syntax for if-statements whenever possible
- ineffassign # Detects when assignments to existing variables are not used
- interfacer # Linter that suggests narrower interface types
- lll # Reports long lines
- makezero # Finds slice declarations with non-zero initial length
- maligned # Tool to detect Go structs that would take less memory if their fields were sorted
- misspell # Finds commonly misspelled English words in comments
- nakedret # Finds naked returns in functions greater than a specified function length
- nestif # Reports deeply nested if statements
Expand All @@ -160,7 +161,6 @@ linters:
- unused # Checks Go code for unused constants, variables, functions and types
- varcheck # Finds unused global variables and constants
- whitespace # Tool for detection of leading and trailing whitespace
- wrapcheck # Checks that errors returned from external packages are wrapped

issues:
max-same-issues: 0
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ coverage: tools/bin/gotestsum ## Takes packages test coverage.
lint: fmt lint/golangci-lint ## Run all linters.

.PHONY: fmt
fmt: tools/bin/goimports tools/bin/gofumpt ## Run goimports and gofumpt.
fmt: tools/bin/goimportz tools/bin/gofumpt ## Run goimportz and gofumpt.
$(call target)
find . -iname "*.go" -not -path "./vendor/**" | xargs -P ${JOBS} ${TOOLS_BIN}/goimports -local=${PKG},$(subst /jsonrpc2,,$(PKG)) -w
find . -iname "*.go" -not -path "./vendor/**" | xargs -P ${JOBS} ${TOOLS_BIN}/goimportz -local=${PKG},$(subst /jsonrpc2,,$(PKG)) -w
find . -iname "*.go" -not -path "./vendor/**" | xargs -P ${JOBS} ${TOOLS_BIN}/gofumpt -s -extra -w

.PHONY: lint/golangci-lint
Expand Down
10 changes: 5 additions & 5 deletions tools/go.mod
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
module go.lsp.dev/jsonrpc2/tools

go 1.15
go 1.16

require (
github.com/golangci/golangci-lint v1.36.0
golang.org/x/tools v0.1.1-0.20210129181147-0cef57b5b584
gotest.tools/gotestsum v1.6.1
mvdan.cc/gofumpt v0.1.0
github.com/golangci/golangci-lint v1.39.0
github.com/zchee/goimportz v0.0.1
gotest.tools/gotestsum v1.6.3
mvdan.cc/gofumpt v0.1.1
)
Loading